Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDP-928] serve/anchor: Make receiver registration handler tenant aware #117

Conversation

ceciliaromao
Copy link
Contributor

What

Upgrade Anchor to use version 2.4.0 which includes the following change
Change SEP24QueryTokenAuthenticateMiddleware and SEP24HeaderTokenAuthenticateMiddleware to parse the home domain from the SEP24 token claims.

Why

The home domain will be used to determine which tenant we're targeting.
Loading the tenant in the request’s context, will allow the MultiTenantDataSourceRouter to select the correct tenant.

Known limitations

N/A

Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
  • This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests December 4, 2023 20:40 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao marked this pull request as draft December 4, 2023 20:40
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests December 7, 2023 13:58 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao self-assigned this Dec 7, 2023
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests December 7, 2023 14:01 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao marked this pull request as ready for review December 7, 2023 14:01
Copy link
Collaborator

@marwen-abid marwen-abid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

internal/anchorplatform/sep24_auth_middleware.go Outdated Show resolved Hide resolved
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests December 8, 2023 12:18 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests December 8, 2023 14:13 — with GitHub Actions Inactive
@stellar stellar deleted a comment from stellar-jenkins Dec 8, 2023
Copy link
Contributor

@CaioTeixeira95 CaioTeixeira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/serve/middleware/middleware.go Outdated Show resolved Hide resolved
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests December 11, 2023 13:11 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao merged commit 0d601b3 into sdp-multitenant Dec 11, 2023
4 of 5 checks passed
@ceciliaromao ceciliaromao deleted the sdp-928_make-receiver-registration-handler-tenant-aware branch December 11, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants